AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
48 stars 23 forks source link

Raw Salt blocks in the world can light up, and will crash client and server if other light sources are placed on them. #100

Closed KajesLorian closed 1 year ago

KajesLorian commented 1 year ago

Describe the bug: I had a salt lamp sitting on a regular block of salt in-world, and when I pick it up with my paxel a bunch of the salt blocks lit up as if they were glowstone. I tried to place the salt lamp back on it and my game crashed. I repeated it and the same thing happened. On the third try I found I could place regular blocks on the lit salt just fine, but placing a torch on the lit block caused the entire server to crash, needing a restart. I can no longer log on without crashing the server.

Versions: Minecraft version:1.19.2 Spelunkery version:1.19.2-0.2.4-forge Moonlight Lib version: 1.19.2-2.2.43-forge Supplementaries: 1.19.2-2.3.20 Fabric API / QSL / Forge version: 43.2.8

Other mods: ModList.txt

Logs: latest.log debug.log

To Reproduce:

  1. Place or remove a light source from a salt block (And salt blocks connected should light up. 2a. Place salt lamp on lit up salt block (client crash) or 2b. Place torch on lit up salt block (server crash)

Expected behavior: A clear and concise description of what you expected to happen.

Screenshots: If applicable, add screenshots to help explain your problem. https://screenshot.help/

Additional info: crash-2023-07-30_17.34.18-client.txt crash-2023-07-30_22.03.47-server.txt

AstralOrdana commented 1 year ago

do you have any salt lamp blocks placed in the area?

KajesLorian commented 1 year ago

I do. There is one about 3 blocks away sitting on some of the glowing salt blocks. There is also the one in my inventory.

AstralOrdana commented 1 year ago

k, pretty sure thats the source of the crash, i'm planning to put out a bug fix update in the next few days and this should be resolved then

KajesLorian commented 1 year ago

Okay

AstralOrdana commented 1 year ago

fixed for 0.2.5