search

Astrocoders / react-native-selectable-text

Capture text selection and customize the action menu
MIT License
224 stars 96 forks source link

fix selection on textView bug in iOS 13 #50

Closed mohamed-aleem closed 4 years ago

mohamed-aleem commented 4 years ago

fix longTapGesture selection bug.

guilhermedecampo commented 4 years ago

hey @mohamed-aleem would be too much ask for a gif with the fix? We are busy and can't test right now.

RossKinsella commented 4 years ago

Here is a gif: https://cl.ly/8cac2a95bb78

That PR appears to solve the issue for me

guilhermedecampo commented 4 years ago

amazing @RossKinsella, thank all!

mohamed-aleem commented 4 years ago

Sorry, didnt notice your message until recently. Glad it worked with you. And thanks. Keep it up :)

jaroslawkrol commented 4 years ago

Hey @mohamed-aleem

I think the problem still occurs on IOS 13.5 on simulator and real device. Everything works correctly, except moving cursors to change highlighted text range. When i try to long-tap on cursor like on @RossKinsella 's gif, current highlighting dissapear and that's all.

Tested on iPhone 7 IOS 13.5 and many simulators. On iOS 12 everything works fine.

nsantacruz commented 4 years ago

@mohamed-aleem, I'm also seeing that multi-word selection is not working on iOS 13.5. I can only select one word and when I try to drag the selector bars, it deselects. It is working fine on iOS 12.

mohamed-aleem commented 4 years ago

Thanks guys, will give it a look to see what needs to be done for the new ios.

nsantacruz commented 4 years ago

Thanks @mohamed-aleem. I'm going to create an issue to better track this and so that other users of this package understand this is a current issue.