AudioKit / AudioKitSynthOne

AudioKit Synth One: Open-Source iOS Synthesizer App
http://audiokitpro.com/synth
MIT License
1.65k stars 214 forks source link

Sequencer Division incorrect #178

Open imprompt opened 2 years ago

imprompt commented 2 years ago

The Synth One "Ultimate Guide" says that the sequencer Division control sets the note length of each step, which seems intuitive. This does not match what happens though:

marcussatellite commented 2 years ago

Hi Malcom,

Good callout. I suggest to maintain backwards compatibility that the documentation be updated to reflect the behavior, which is that the divisor is of the 1/4 note of the tempo, not the 1/1 note.

I would object to changing the sequencer behavior itself…this would break so many presents, and so many users’ experiences.

Marcus

On Apr 16, 2022, at 7:32 AM, Malcolm Haylock @.***> wrote:

The Synth One "Ultimate Guide" says that the sequencer Division control sets the note length of each step, which seems intuitive. This does not match what happens though:

Open patch 0:init from Starter bank Tempo should be 120 bpm Set sequencer to "Seq" and switch on Set Division to 1/4 note. Play a note - each step is 4x too fast (i.e. 16th note). — Reply to this email directly, view it on GitHub https://github.com/AudioKit/AudioKitSynthOne/issues/178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5L5X2FYZ5K3BFSPZSQ2D3VFLFQFANCNFSM5TSOPFAA. You are receiving this because you are subscribed to this thread.

imprompt commented 2 years ago

Thanks for the quick feedback. I understand the dilemma, but it's a shame as the most intuitive setup is to have the Division represent the step duration. The current setup requires a x4 mental calculation.

e.g. I want the step to be 1/16 note triplets (=1/24) Therefore the duration must be set to 4x 1/24 = 1/6 = 1/4 note triplets.

If people are already doing this then I'm surprised this issue has not been raised before. Anyway it's not a critical problem, just something that would improve the usability going forward, so I can live with it.