search

AustralianAntarcticDivision / SOmap

Southern Ocean round maps
https://australianantarcticdivision.github.io/SOmap/
24 stars 6 forks source link

SOauto_crop failure #83

Closed raymondben closed 4 years ago

raymondben commented 4 years ago

Suspect is due to sf changes, don't know if it's related to https://github.com/AustralianAntarcticDivision/SOmap/issues/82.

> a<-SOmap_auto(c(0, 50), c(-70, -50))
Warning message:
In rgdal::rawTransform(projfrom, projto, nrow(xy), xy[, 1], xy[,  :
  Using PROJ not WKT2 strings
> x<-SOauto_crop(SOmap_data$fronts_orsi,  a)
Warning message:
In spTransform(xSP, CRSobj, ...) :
  NULL source CRS comment, falling back to PROJ string
> x
[1] "Error in h(simpleError(msg, call)) : \n  error in evaluating the argument 'x' in selecting a method for function 'addAttrToGeom': list item(s) not of class sfg\n"
attr(,"class")
[1] "try-error"
attr(,"condition")
<simpleError in h(simpleError(msg, call)): error in evaluating the argument 'x' in selecting a method for function 'addAttrToGeom': list item(s) not of class sfg>

Related: would it make sense to remove the try(..., silent = TRUE) from the SOauto_crop code? In this case, at least, this made it harder to figure out which step had failed.

raymondben commented 4 years ago

Working now, suspect it was the same issue as #82