many minor spelling / simplificationchanges but also some Reflection …

AutoMapper / AutoMapper.Collection

AutoMapper support for updating existing collections by equivalency

MIT License

245 stars 59 forks source link

many minor spelling / simplificationchanges but also some Reflection … #149

Closed DickBaker closed 2 years ago

DickBaker commented 4 years ago

…improvements and optimisations

I got bored fighting GH flow and meantime decided to tilt at up-level package, but I'll be back on EF bits shortly. Tasteful, thanks for your moral support but feel free to criticise my code anyway!

DickBaker commented 4 years ago

delighted on AutoMapper/AutoMapper.Collection.EFCore that Tasteful has created PR42=PR40+PR41 and apparently fully overcome the GH DIFF sprites that were bugging me, so hope that will mainstream soon as I have more to contribute there. Difficult to decide size of a PR (SRP etc) so apologies if this PR149 here is a bit heavy (designed to clear the air). Enjoy!

TylerCarlson1 commented 4 years ago

I agree with @Tasteful with the double negatives. For if(bool) return; I personally find it harder to read on the same line. ?? with Exception being thrown is also hard to read personally. Most of the other changes I find easily enough.

That being said we don't have a standard for how it's coded. And for readability is much more important than making it small as possible.