search

Automattic / VIP-Coding-Standards

PHP_CodeSniffer ruleset to enforce WordPress VIP coding standards.
https://wpvip.com/documentation/how-to-install-php-code-sniffer-for-wordpress-com-vip/
Other
237 stars 40 forks source link

Make VIPCS PHP 8-friendlier #727

Closed rebeccahum closed 1 year ago

rebeccahum commented 2 years ago

Bug Description

A lot of users are running into https://github.com/WordPress/WordPress-Coding-Standards/pull/1935 since we're waiting on WPCS 3.0 and the current version of 2.3.0 does not have the fix included. Creating new issue for tracking purposes.

swissspidy commented 2 years ago

Would it be an option to change the "wp-coding-standards/wpcs": "^2.3" requirement to `"wp-coding-standards/wpcs": "^2.3 || dev-develop"?

This way, consumers with minimum-stability: 'dev' could use the develop branch including the fix, while everyone else can still be on 2.3.0. Assuming of course that this package here works well together with the develop version.

Haven't tested this though, but I think it should work.

jrfnl commented 2 years ago

@swissspidy That won't work as WPCS dev-develop contains breaking changes which means some sniffs here will need adjusting.

christianc1 commented 2 years ago

Could we change the requirement to "wp-coding-standards/wpcs": "^2.3 || dev-master#2.3.0-fix-vsprintf"? Opened #730 if this is viable.

jrfnl commented 2 years ago

FYI: we're getting close to releasing WPCS 3.0.0. No promises on timeline, but I'm hoping within the next month.

ThirdEyeRose commented 1 year ago

@jrfnl , I assume the timeline for the release of WPCS 3.0.0 has shifted? Do you know if there's an updated ETA for WPCS 3.0.0?

kkmuffme commented 1 year ago

3.0.0 is released