$insideIfConditionalReturn has a default value of 0;
And that value is only ever increased;
The $insideIfConditionalReturn >= 0 condition will always be true.
So this condition can be safely removed, just like the - now unused - assignments to the variable.
The original condition was introduced with the introduction of the sniff in #177. The condition was adjusted in #291, which made the logic redundant.
Looking at the sniff, I believe the intention was to only flag the "return outside condition missing" when not all control structure paths had a return statement, but this was never really properly checked as the only control structures taken into account are if control structures.
I believe it would be good to improve the sniff to handle more control structures (switch, while etc) and to not throw the "return outside condition missing" error if all possible paths have a return statement, but that is outside the scope of the current PR.
I will add a note to this effect to the review ticket for this sniff - #520.
Given that:
$insideIfConditionalReturnhas a default value of0;$insideIfConditionalReturn >= 0condition will always betrue.So this condition can be safely removed, just like the - now unused - assignments to the variable.
The original condition was introduced with the introduction of the sniff in #177. The condition was adjusted in #291, which made the logic redundant.
Looking at the sniff, I believe the intention was to only flag the "return outside condition missing" when not all control structure paths had a
returnstatement, but this was never really properly checked as the only control structures taken into account areifcontrol structures.I believe it would be good to improve the sniff to handle more control structures (
switch,whileetc) and to not throw the "return outside condition missing" error if all possible paths have areturnstatement, but that is outside the scope of the current PR.I will add a note to this effect to the review ticket for this sniff - #520.