Automattic / a8c-ci-toolkit-buildkite-plugin

A caching plugin that can be invoked from your build script.
22 stars 5 forks source link

Refine message in `annotate_test_failures` when optional config missing #74

Closed mokagio closed 1 year ago

mokagio commented 1 year ago

I configured Slack reporting in https://github.com/wordpress-mobile/gutenberg-mobile/pull/6134 based on what I saw in WordPress iOS and was surprised by the info message I got. Why did that string work in WP but not on my project? I turns out that WP set the webhook via an env var. Admittedly, It didn't take long to find that out by looking at the code. Still, I decided to update the "Slack skipped" message to something I think would have been clearer for me at the time.


mokagio commented 1 year ago

Thanks @AliSoftware. That was fast! 😄