Add cocoapod flags to another command

Automattic / a8c-ci-toolkit-buildkite-plugin

A caching plugin that can be invoked from your build script.

22 stars 5 forks source link

Add cocoapod flags to another command #87

Closed crazytonyli closed 7 months ago

crazytonyli commented 7 months ago

Following up https://github.com/Automattic/a8c-ci-toolkit-buildkite-plugin/pull/86#issuecomment-2043868041

[x] I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

crazytonyli commented 7 months ago

Ops, sorry, I didn't noticed this PR contains old commits that are squash-merged into the trunk branch.

AliSoftware commented 7 months ago

Even after your force-push to fix the old squash-merged commits, there's still a tab-vs-spaces indentation inconsistency with line 18 using spaces while the rest of the file uses tabs, which might not be super visible on GitHub web/desktop, but makes the ;; misaligned if one's tab-width is not set to 8 🙃 (I only noticed it because I initially reviewed the PR on GitHub mobile 😅 )

crazytonyli commented 7 months ago

🙈 I didn't see that at all. Addressed in https://github.com/Automattic/a8c-ci-toolkit-buildkite-plugin/pull/87/commits/af60ecda466a2458d01f2410eaef257e97f78ae4