search

Automattic / developer

In your WordPress, developing locally
http://vip.wordpress.com
GNU General Public License v2.0
472 stars 103 forks source link

wp-cli command for the developer plugin, and basic test implementation #44

Closed danielbachhuber closed 8 years ago

nb commented 11 years ago

Three things:

danielbachhuber commented 11 years ago

I didn't think to use the plugin activation facility in WP_CLI. Might be useful, but not sure

The tests are there because that's what I was supposed to be working on Saturday. I didn't make as much progress as I wanted to. I can remove from the branch if you'd like.

On Apr 29, 2013, at 4:57 AM, Nikolay Bachiyski notifications@github.com wrote:

Three things:

Why didn't you use WP_CLI's plugin installation/activation functionality? What's the point of smuggling the tests into into this, totally unrelated, pull request? I like the extracted plugin_install. — Reply to this email directly or view it on GitHub.

nb commented 11 years ago

If you can take out the tests from this PR that would be great. Of course, another PR with meaningful tests would be appreciated and will be merged quickly :-)