Automattic / ghactivity

WordPress plugin. Build reports of all your GitHub activity.
https://wordpress.org/plugins/ghactivity/
6 stars 2 forks source link

Get person's details: do not grab details from the wrong GitHub username #8

Closed jeherve closed 6 years ago

jeherve commented 6 years ago

The get_person_details function currently makes a call to the GitHub API to get information about each tracked user, and store that information in term meta: https://github.com/jeherve/ghactivity/blob/8633d8c5b3599dad4c13d8f030422222aa41c487/core.ghactivity.php#L139 https://github.com/jeherve/ghactivity/blob/8633d8c5b3599dad4c13d8f030422222aa41c487/core.ghactivity.php#L557

This works well for most people, but not for folks like @oskosk. We need to fix this so it grabs data based on the GitHub username, not display name. I have not investigated yet, but we may need to review how we generate the terms in the ghactivity_actor taxonomy in the first place.