search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Issue with Google Fonts persistence after Jetpack deactivation in WordPress 6.5 (RC2) #36371

Open briceduclos opened 7 months ago

briceduclos commented 7 months ago

Impacted plugin

Jetpack

Quick summary

In WordPress 6.5 (RC2), after making changes in the Font Library, deactivating the Jetpack Google Fonts module or the entire Jetpack plugin results in all previously added Google Fonts being permanently printed (more than 600 lines) on the website's front-end. This happens without providing users an option to remove these fonts.

Steps to reproduce

  1. Install WordPress 6.5 RC2.
  2. Activate the Jetpack Google Fonts module.
  3. Install a new Google Font using the Font Library feature (which saves the font settings to the database).
  4. Deactivate the Jetpack Google Fonts module.
  5. Check the website's front end and observe that all previously added Google Fonts are still being loaded, with no way to remove them.

A clear and concise description of what you expected to happen.

No response

What actually happened

Jetpack adds its Google Fonts using the wp_theme_json_data_default hook, which means the fonts cannot be managed or removed through the Font Library. https://github.com/Automattic/jetpack/pull/33203

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

jeherve commented 7 months ago

Thanks for the report!

Could you let me know what version of Jetpack is currently installed on your site, or was installed before you deactivated it?

cc @arthur791004 who recently worked on #35986.

briceduclos commented 7 months ago

I've tested with the latest version 13.2.1.