Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

VideoPress: Recently uploaded private video thumbnails result in a 404 error #39524

Open ivan-ottinger opened 2 months ago

ivan-ottinger commented 2 months ago

Image

There are two related issues:

  1. When saving the new thumbnail for a video, the old thumbnail displays for a second
  2. When reloading the page shortly after clicking the Save changes button, the process gets interrupted and results in the 404 of the thumbnail image.

I would say that fixing the issue 1 might reduce the occurrence of the issue 2 - because I can imagine that when the user sees the old thumbnail in there after saving the changes, they may want to reload the page quickly - which then triggers the issue 2.

To fix the issue 2, I think we may need to review the logic that changes the thumbnail and make sure that if the process is interrupted at any point, we will fall back to the original thumbnail.

Steps to reproduce:

We were able to reproduce the issue on a Jurassic Ninja site.

  1. Navigate to Jetpack > VideoPress.
  2. Upload a new video and open it by clicking on the Edit video details button.
  3. Make the video private.
  4. Choose a custom thumbnail for it and then while the changes are being saved, quickly reload the page.
  5. You should be able to observe both issues described in this issue.

Related discussion: p1726809473248039-slack-C02LT75D3. Similar issue: https://github.com/Automattic/jetpack/issues/27169.

alinclamba commented 2 months ago

Askd the user based on the Slack conversation: p1726845384484939/1726809473.248039-slack-C02LT75D3

phcp commented 2 months ago

I transferred the issue to the Jetpack repo since it's related to the plugin dashboard, and it's maintained by @Automattic/jetpack-agora, so they can follow up on it.

StefMattana commented 1 month ago

As a reference, I replied to the user with a new follow-up ticket: 8822017-zen