Test against WordPress 5.4 RC

[benlk]

Without AMP

Plugin settings:

• [x] Does the plugin settings page work? /wp-admin/options-general.php?page=pym-embed-settings
• [x] Does the plugin info page work? /wp-admin/tools.php?page=pym-embeds-info

Shortcode tests:

• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymoptions=" xdomain: '\\*\.npr\.org' "]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" class="one two three four float-left mw_50"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align=""]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="none"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="left"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="center"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="right"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="wide"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="full"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" id="extremely_specific_id"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]

Gutenberg tests:

• [x] the block, when inserted, prompts users for a URL
• [x] the block's alignment, custom classes, custom ID, and other options are respected.
• [x] the block uses the default pymsrc URL if the pymsrc attribute is not set
• [x] on a site with Gutenberg not installed, the plugin functions
• [x] on a without Gutenberg installed, the plugin functions

With AMP

Plugin settings:

• [x] Does the plugin settings page work? /wp-admin/options-general.php?page=pym-embed-settings
• [x] Does the plugin info page work? /wp-admin/tools.php?page=pym-embeds-info

Shortcode tests:

• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymoptions=" xdomain: '\\*\.npr\.org' "]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" class="one two three four float-left mw_50"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align=""]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="none"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="left"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="center"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="right"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="wide"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="full"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" id="extremely_specific_id"]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]
• [x] [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]

Gutenberg tests:

• [x] the block, when inserted, prompts users for a URL
• [x] the block's alignment, custom classes, custom ID, and other options are respected.
• [x] the block uses the default pymsrc URL if the pymsrc attribute is not set
• [x] on a site with Gutenberg not installed, the plugin functions
• [x] on a without Gutenberg installed, the plugin functions

[benlk]

Odd thing seen in WP 5.4 w/ AMP plugin enabled: the main embed item in the side panel is wider than the side panel, by the width of its border beyond 100% width.

After a cursory review of WP Core blocks, it looks like all controls are direct children of panels, and in the case of this control, that is not the case with our plugin.