Closed notandyvee closed 3 months ago
2 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
App Name | Simplenote Android | |
Build Type | Debug | |
Commit | 97c6124660952d7d1148f1b17730336b52e0f02f | |
Direct Download | simplenote-android-prototype-build-pr1668-97c6124-0190ec87-362e-41fc-b161-5c361c5f9aa4.apk |
Just a heads up - I tested with a regular, non cursed account, and both magic links and code work as expected. So I think we can ignore the "going to back to title screen after entering code" issue.
@roundhill I did everything except:
Also one more nice thing iOS does is not require you to enter your email again if you select Enter password:
There may be changes that need to be made with simperium. I'll confirm. So either way best to wait until we discuss this.
@khaykov ready for re-review. After your thorough review I found some small general fragment issues and viewmodel issues. I also updated some of the error messages. Again, keep in mind we have to balance security vs transparency here.
@notandyvee Thanks for the changes! I found one issue - when opening magic link, the app "closes" after logging you in:
Thanks @khaykov . I'll investigate. The reason this is happening seems to be related to a bug I was fixing. Originally I would call Simplenote#loginWithToken
and start NotesActivity
. But doing so caused two NoteActivity
s to pop up. During my testing it worked. But maybe I missed something.
Hey @khaykov , so I think I fixed it. If you want to re-test. Idky since simperium is a bit of a black box for me. But I was able to reproduce what you encountered. The change I made should fix it. Let me know if you run into any problems.
@roundhill changes requested made and and also fixed the issue with the code confirmation. Not sure what happened.
lol. sorry. Missed your message.
Fix
This PR makes some updates related to the magic link flow.
Test
Login with Wordpress
The main reason to test this is because I update the deprecated
onActivityForResult
. It was just easier to handle it in the fragment.Login With Magic Link
Login With Magic Link Code
Release
No Additional release update needed.