Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.06k stars 284 forks source link

Dont use tags on shortcut #1593

Closed charliescheer closed 6 months ago

charliescheer commented 6 months ago

Fix

Currently we have a few different ways to create and open new notes from outside of Simplenote:

If you select one of those options and inside the app you have a tag selected then the new note that is created is tagged. This is probably fine ish... but since you can't see what the tag is when the shortcuts are run it is a little odd if you weren't expecting it. We shouldn't add the tag when making a new note. So here we are not doing that.

fixes #1424

Test

  1. In Simplenote select a tag from the sidebar
  2. background the app and long press on the Simplenote icon, select new note. When the editor appears confirm that the new note does not have a tag
  3. Go to the shortcut app, create a new shortcut, add action, select Simplenote and add an Open New Note action. Run the action and confirm that the new note that is opened is not tagged
  4. Go to the desktop and long press on the Home Screen, when the home screen edit appears tap on the plus, search the widgets for Simplenote, and add the new note widget. Tap on that widget, confirm that no tag is added to the note that is created.

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.