Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.06k stars 284 forks source link

Charlie/shortcut data loss failsafe #1600

Closed charliescheer closed 5 months ago

charliescheer commented 5 months ago

Fix

With the new append shortcuts there is the possibility that your shortcut fails and if that happens the content you sent to the shortcut will be lost. There isn't a lot we can do to prevent that unfortunately, but we can attempt to save the content locally and then restore it on the next launch. So in this PR I have added a content recovery mechanism incase a shortcut fails. That way the user doesn't have to restore the written content if a shortcut fails.

Test

  1. Build and run simplenote ios
  2. Open up the shortcuts app and create an append to note or a create note with content shortcut
  3. Disable the internet connections
  4. run the shortcut
  5. launch simplenote.

    • [ ] Confirm that a new note is created with the content from your shortcut

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

wpmobilebot commented 5 months ago

You can test the changes in simplenote-ios from this Pull Request by:

If you need access to App Center, please ask a maintainer to add you.