Closed katinthehatsite closed 3 months ago
Thanks for the review @jeroenpf
When i have the assistant open for one site, and then create a new site, the focus of the studio app switches to the new site, but i still see the messages of the site that was previously active. This is perhaps a pre-existing problem so if you feel its not something we should fix in this PR its probably a good idea to create a separate issue for it.
For this bit, this is already present on trunk. Let's open the issue to fix it, I think this will require some refactoring work on content-tab-assistant.tsx
. I will add a new issue and link it here once done.
Opened the issue for creating a new site and messages not being empty: https://github.com/Automattic/dotcom-forge/issues/7762
I looked through the design and noticed that the Welcome messages should stay on the screen when the message is set but the prompts should disappear. I will refactor a bit and then re-request the review
@jeroenpf I made a couple of changes such as:
WelcomeComponent
Let me know what you think!
Thanks for implementing this @katinthehatsite.
The suggested action buttons should have hover and focus states. You can find these on the Components page in the Figma file.
Default | Hover | Focussed |
---|---|---|
The vertical padding for these buttons should be a little less than the regular messages. px-3 py-2
instead of p-3
.
Thanks @matt-west - I will update based on your comment 👍 did not notice that bit in Figma
Related to https://github.com/Automattic/dotcom-forge/issues/7411
Proposed Changes
This PR adds a welcome component that offers two welcome messages and three prompts:
Testing Instructions
STUDIO_AI=true npm start
Some notes
Pre-merge Checklist