Automattic / studio

Studio by WordPress.com, a free desktop app that helps developers streamline their local WordPress development workflow.
https://developer.wordpress.com/studio/
GNU General Public License v2.0
172 stars 17 forks source link

Studio: Add the initial welcome prompts UI component #245

Closed katinthehatsite closed 3 months ago

katinthehatsite commented 3 months ago

Related to https://github.com/Automattic/dotcom-forge/issues/7411

Proposed Changes

This PR adds a welcome component that offers two welcome messages and three prompts:

Testing Instructions

Capture d’écran, le 2024-06-13 à 16 51 19

Some notes

Pre-merge Checklist

katinthehatsite commented 3 months ago

Thanks for the review @jeroenpf

When i have the assistant open for one site, and then create a new site, the focus of the studio app switches to the new site, but i still see the messages of the site that was previously active. This is perhaps a pre-existing problem so if you feel its not something we should fix in this PR its probably a good idea to create a separate issue for it.

For this bit, this is already present on trunk. Let's open the issue to fix it, I think this will require some refactoring work on content-tab-assistant.tsx. I will add a new issue and link it here once done.

katinthehatsite commented 3 months ago

Opened the issue for creating a new site and messages not being empty: https://github.com/Automattic/dotcom-forge/issues/7762

katinthehatsite commented 3 months ago

I looked through the design and noticed that the Welcome messages should stay on the screen when the message is set but the prompts should disappear. I will refactor a bit and then re-request the review

katinthehatsite commented 3 months ago

@jeroenpf I made a couple of changes such as:

Let me know what you think!

matt-west commented 3 months ago

Thanks for implementing this @katinthehatsite.

The suggested action buttons should have hover and focus states. You can find these on the Components page in the Figma file.

Default Hover Focussed
image image image

The vertical padding for these buttons should be a little less than the regular messages. px-3 py-2 instead of p-3.

katinthehatsite commented 3 months ago

Thanks @matt-west - I will update based on your comment 👍 did not notice that bit in Figma