Automattic / vip-go-mu-plugins

The development repo for mu-plugins used on the WordPress VIP Platform.
https://docs.wpvip.com/
GNU General Public License v2.0
198 stars 102 forks source link

Update `Tracks_Event_DTO` by adding new properties and updating the names of legacy properties #5990

Closed mehmoodak closed 1 week ago

mehmoodak commented 2 weeks ago

Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

Pre-deploy checklist

Steps to Test

  1. Add following code

    function record_telemetry_event_in_footer() {
        $tracks = new \Automattic\VIP\Telemetry\Tracks();
        $tracks->record_event( 'local_event', [
            'hello' => 'vip',
        ] );
    }
    add_action('admin_footer', 'record_telemetry_event_in_footer');
  2. Load the admin, wait for some time to see the event appear in Tracks and verify the event.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.53%. Comparing base (0affaad) to head (a327397). Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
telemetry/tracks/tracks-utils.php 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5990 +/- ## ============================================= + Coverage 30.49% 30.53% +0.03% - Complexity 4808 4811 +3 ============================================= Files 289 289 Lines 21165 21161 -4 ============================================= + Hits 6454 6461 +7 + Misses 14711 14700 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud