search

Automattic / vip-support

Manages the VIP Support Users on your site
GNU General Public License v2.0
12 stars 4 forks source link

wp_user_roles missing default roles on new sites #58

Closed mattoperry closed 3 years ago

mattoperry commented 6 years ago

In the case of multisite (and possibly non-multisite, though I haven't checked) new sites end up with corrupted roles options.

Repro steps:

To fix, we run wp roles reset --all on the affected site.

Example:

Subsite 5 of abril-com.go-vip.co (at this time) runs the abril-master theme, which defines a few additional roles.

The initial value of wp_user_roles was:

wp_5_user_roles a:6:{s:7:"blogger";a:2:{s:4:"name";s:9:"Blogueiro";s:12:"capabilities";a:18:{s:9:"edit_post";b:1;s:10:"edit_posts";b:1;s:17:"publish_galleries";b:1;s:14:"publish_videos";b:1;s:12:"assign_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:12:"super-editor";a:2:{s:4:"name";s:12:"Super editor";s:12:"capabilities";a:86:{s:13:"switch_themes";b:1;s:11:"edit_themes";b:1;s:18:"edit_theme_options";b:1;s:9:"customize";b:1;s:10:"edit_files";b:1;s:14:"manage_options";b:1;s:17:"moderate_comments";b:1;s:17:"manage_categories";b:1;s:12:"manage_links";b:1;s:12:"upload_files";b:1;s:10:"edit_posts";b:1;s:17:"edit_others_posts";b:1;s:20:"edit_published_posts";b:1;s:13:"publish_posts";b:1;s:10:"edit_pages";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:17:"edit_others_pages";b:1;s:20:"edit_published_pages";b:1;s:13:"publish_pages";b:1;s:12:"delete_pages";b:1;s:19:"delete_others_pages";b:1;s:22:"delete_published_pages";b:1;s:12:"delete_posts";b:1;s:19:"delete_others_posts";b:1;s:22:"delete_published_posts";b:1;s:20:"delete_private_posts";b:1;s:18:"edit_private_posts";b:1;s:18:"read_private_posts";b:1;s:20:"delete_private_pages";b:1;s:18:"edit_private_pages";b:1;s:18:"read_private_pages";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:21:"edit_others_galleries";b:1;s:17:"publish_galleries";b:1;s:22:"read_private_galleries";b:1;s:16:"delete_galleries";b:1;s:24:"delete_private_galleries";b:1;s:26:"delete_published_galleries";b:1;s:23:"delete_others_galleries";b:1;s:22:"edit_private_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:18:"edit_others_videos";b:1;s:14:"publish_videos";b:1;s:19:"read_private_videos";b:1;s:13:"delete_videos";b:1;s:21:"delete_private_videos";b:1;s:23:"delete_published_videos";b:1;s:20:"delete_others_videos";b:1;s:19:"edit_private_videos";b:1;s:21:"edit_published_videos";b:1;s:16:"manage_all_blogs";b:1;s:12:"assign_blogs";b:1;s:12:"delete_blogs";b:1;s:10:"edit_blogs";b:1;s:12:"manage_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:11:"publicidade";a:2:{s:4:"name";s:11:"Publicidade";s:12:"capabilities";a:13:{s:14:"manage_options";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;}}s:10:"assinatura";a:2:{s:4:"name";s:10:"Assinatura";s:12:"capabilities";a:15:{s:18:"edit_theme_options";b:1;s:9:"customize";b:1;s:14:"manage_options";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;}}s:11:"vip_support";a:2:{s:4:"name";s:11:"VIP Support";s:12:"capabilities";a:1:{s:4:"read";b:1;}}s:20:"vip_support_inactive";a:2:{s:4:"name";s:22:"VIP Support (inactive)";s:12:"capabilities";a:1:{s:4:"read";b:1;}}}

after the above cli, the value was:

wp_5_user_roles a:11:{s:7:"blogger";a:2:{s:4:"name";s:9:"Blogueiro";s:12:"capabilities";a:37:{s:9:"edit_post";b:1;s:10:"edit_posts";b:1;s:17:"publish_galleries";b:1;s:14:"publish_videos";b:1;s:12:"assign_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;s:4:"read";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:12:"delete_posts";b:1;s:12:"upload_files";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:16:"delete_galleries";b:1;s:26:"delete_published_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:13:"delete_videos";b:1;s:23:"delete_published_videos";b:1;s:21:"edit_published_videos";b:1;}}s:12:"super-editor";a:2:{s:4:"name";s:12:"Super editor";s:12:"capabilities";a:86:{s:13:"switch_themes";b:1;s:11:"edit_themes";b:1;s:18:"edit_theme_options";b:1;s:9:"customize";b:1;s:10:"edit_files";b:1;s:14:"manage_options";b:1;s:17:"moderate_comments";b:1;s:17:"manage_categories";b:1;s:12:"manage_links";b:1;s:12:"upload_files";b:1;s:10:"edit_posts";b:1;s:17:"edit_others_posts";b:1;s:20:"edit_published_posts";b:1;s:13:"publish_posts";b:1;s:10:"edit_pages";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:17:"edit_others_pages";b:1;s:20:"edit_published_pages";b:1;s:13:"publish_pages";b:1;s:12:"delete_pages";b:1;s:19:"delete_others_pages";b:1;s:22:"delete_published_pages";b:1;s:12:"delete_posts";b:1;s:19:"delete_others_posts";b:1;s:22:"delete_published_posts";b:1;s:20:"delete_private_posts";b:1;s:18:"edit_private_posts";b:1;s:18:"read_private_posts";b:1;s:20:"delete_private_pages";b:1;s:18:"edit_private_pages";b:1;s:18:"read_private_pages";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:21:"edit_others_galleries";b:1;s:17:"publish_galleries";b:1;s:22:"read_private_galleries";b:1;s:16:"delete_galleries";b:1;s:24:"delete_private_galleries";b:1;s:26:"delete_published_galleries";b:1;s:23:"delete_others_galleries";b:1;s:22:"edit_private_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:18:"edit_others_videos";b:1;s:14:"publish_videos";b:1;s:19:"read_private_videos";b:1;s:13:"delete_videos";b:1;s:21:"delete_private_videos";b:1;s:23:"delete_published_videos";b:1;s:20:"delete_others_videos";b:1;s:19:"edit_private_videos";b:1;s:21:"edit_published_videos";b:1;s:16:"manage_all_blogs";b:1;s:12:"assign_blogs";b:1;s:12:"delete_blogs";b:1;s:10:"edit_blogs";b:1;s:12:"manage_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:11:"publicidade";a:2:{s:4:"name";s:11:"Publicidade";s:12:"capabilities";a:13:{s:14:"manage_options";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;}}s:10:"assinatura";a:2:{s:4:"name";s:10:"Assinatura";s:12:"capabilities";a:15:{s:18:"edit_theme_options";b:1;s:9:"customize";b:1;s:14:"manage_options";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;}}s:11:"vip_support";a:2:{s:4:"name";s:11:"VIP Support";s:12:"capabilities";a:1:{s:4:"read";b:1;}}s:20:"vip_support_inactive";a:2:{s:4:"name";s:22:"VIP Support (inactive)";s:12:"capabilities";a:1:{s:4:"read";b:1;}}s:13:"administrator";a:2:{s:4:"name";s:13:"Administrator";s:12:"capabilities";a:104:{s:13:"switch_themes";b:1;s:11:"edit_themes";b:1;s:16:"activate_plugins";b:1;s:12:"edit_plugins";b:1;s:10:"edit_users";b:1;s:10:"edit_files";b:1;s:14:"manage_options";b:1;s:17:"moderate_comments";b:1;s:17:"manage_categories";b:1;s:12:"manage_links";b:1;s:12:"upload_files";b:1;s:6:"import";b:1;s:15:"unfiltered_html";b:1;s:10:"edit_posts";b:1;s:17:"edit_others_posts";b:1;s:20:"edit_published_posts";b:1;s:13:"publish_posts";b:1;s:10:"edit_pages";b:1;s:4:"read";b:1;s:8:"level_10";b:1;s:7:"level_9";b:1;s:7:"level_8";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:17:"edit_others_pages";b:1;s:20:"edit_published_pages";b:1;s:13:"publish_pages";b:1;s:12:"delete_pages";b:1;s:19:"delete_others_pages";b:1;s:22:"delete_published_pages";b:1;s:12:"delete_posts";b:1;s:19:"delete_others_posts";b:1;s:22:"delete_published_posts";b:1;s:20:"delete_private_posts";b:1;s:18:"edit_private_posts";b:1;s:18:"read_private_posts";b:1;s:20:"delete_private_pages";b:1;s:18:"edit_private_pages";b:1;s:18:"read_private_pages";b:1;s:12:"delete_users";b:1;s:12:"create_users";b:1;s:17:"unfiltered_upload";b:1;s:14:"edit_dashboard";b:1;s:14:"update_plugins";b:1;s:14:"delete_plugins";b:1;s:15:"install_plugins";b:1;s:13:"update_themes";b:1;s:14:"install_themes";b:1;s:11:"update_core";b:1;s:10:"list_users";b:1;s:12:"remove_users";b:1;s:13:"promote_users";b:1;s:18:"edit_theme_options";b:1;s:13:"delete_themes";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:21:"edit_others_galleries";b:1;s:17:"publish_galleries";b:1;s:22:"read_private_galleries";b:1;s:16:"delete_galleries";b:1;s:24:"delete_private_galleries";b:1;s:26:"delete_published_galleries";b:1;s:23:"delete_others_galleries";b:1;s:22:"edit_private_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:18:"edit_others_videos";b:1;s:14:"publish_videos";b:1;s:19:"read_private_videos";b:1;s:13:"delete_videos";b:1;s:21:"delete_private_videos";b:1;s:23:"delete_published_videos";b:1;s:20:"delete_others_videos";b:1;s:19:"edit_private_videos";b:1;s:21:"edit_published_videos";b:1;s:16:"manage_all_blogs";b:1;s:12:"assign_blogs";b:1;s:12:"delete_blogs";b:1;s:10:"edit_blogs";b:1;s:12:"manage_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:6:"editor";a:2:{s:4:"name";s:6:"Editor";s:12:"capabilities";a:74:{s:17:"moderate_comments";b:1;s:12:"manage_links";b:1;s:12:"upload_files";b:1;s:15:"unfiltered_html";b:1;s:10:"edit_posts";b:1;s:17:"edit_others_posts";b:1;s:20:"edit_published_posts";b:1;s:13:"publish_posts";b:1;s:10:"edit_pages";b:1;s:4:"read";b:1;s:7:"level_7";b:1;s:7:"level_6";b:1;s:7:"level_5";b:1;s:7:"level_4";b:1;s:7:"level_3";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:17:"edit_others_pages";b:1;s:20:"edit_published_pages";b:1;s:13:"publish_pages";b:1;s:12:"delete_pages";b:1;s:19:"delete_others_pages";b:1;s:22:"delete_published_pages";b:1;s:12:"delete_posts";b:1;s:19:"delete_others_posts";b:1;s:22:"delete_published_posts";b:1;s:20:"delete_private_posts";b:1;s:18:"edit_private_posts";b:1;s:18:"read_private_posts";b:1;s:20:"delete_private_pages";b:1;s:18:"edit_private_pages";b:1;s:18:"read_private_pages";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:21:"edit_others_galleries";b:1;s:17:"publish_galleries";b:1;s:22:"read_private_galleries";b:1;s:16:"delete_galleries";b:1;s:24:"delete_private_galleries";b:1;s:26:"delete_published_galleries";b:1;s:23:"delete_others_galleries";b:1;s:22:"edit_private_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:18:"edit_others_videos";b:1;s:14:"publish_videos";b:1;s:19:"read_private_videos";b:1;s:13:"delete_videos";b:1;s:21:"delete_private_videos";b:1;s:23:"delete_published_videos";b:1;s:20:"delete_others_videos";b:1;s:19:"edit_private_videos";b:1;s:21:"edit_published_videos";b:1;s:16:"manage_all_blogs";b:1;s:12:"assign_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:6:"author";a:2:{s:4:"name";s:6:"Author";s:12:"capabilities";a:40:{s:12:"upload_files";b:1;s:10:"edit_posts";b:1;s:20:"edit_published_posts";b:1;s:13:"publish_posts";b:1;s:4:"read";b:1;s:7:"level_2";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:12:"delete_posts";b:1;s:22:"delete_published_posts";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:17:"publish_galleries";b:1;s:16:"delete_galleries";b:1;s:26:"delete_published_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:14:"publish_videos";b:1;s:13:"delete_videos";b:1;s:23:"delete_published_videos";b:1;s:21:"edit_published_videos";b:1;s:12:"assign_blogs";b:1;s:14:"edit_blog_post";b:1;s:14:"read_blog_post";b:1;s:16:"delete_blog_post";b:1;s:15:"edit_blog_posts";b:1;s:22:"edit_others_blog_posts";b:1;s:18:"publish_blog_posts";b:1;s:23:"read_private_blog_posts";b:1;s:17:"delete_blog_posts";b:1;s:25:"delete_private_blog_posts";b:1;s:27:"delete_published_blog_posts";b:1;s:24:"delete_others_blog_posts";b:1;s:23:"edit_private_blog_posts";b:1;s:25:"edit_published_blog_posts";b:1;}}s:11:"contributor";a:2:{s:4:"name";s:11:"Contributor";s:12:"capabilities";a:20:{s:10:"edit_posts";b:1;s:4:"read";b:1;s:7:"level_1";b:1;s:7:"level_0";b:1;s:12:"delete_posts";b:1;s:12:"upload_files";b:1;s:12:"edit_gallery";b:1;s:12:"read_gallery";b:1;s:14:"delete_gallery";b:1;s:14:"edit_galleries";b:1;s:16:"delete_galleries";b:1;s:26:"delete_published_galleries";b:1;s:24:"edit_published_galleries";b:1;s:10:"edit_video";b:1;s:10:"read_video";b:1;s:12:"delete_video";b:1;s:11:"edit_videos";b:1;s:13:"delete_videos";b:1;s:23:"delete_published_videos";b:1;s:21:"edit_published_videos";b:1;}}s:10:"subscriber";a:2:{s:4:"name";s:10:"Subscriber";s:12:"capabilities";a:2:{s:4:"read";b:1;s:7:"level_0";b:1;}}}

Theory: something in https://github.com/Automattic/vip-support/blob/0e7cfd3c9decfae305faf2c9c5463e146f6d52a3/class-vip-support-role.php#L151 is clobbering the option.

htdat commented 3 years ago

This issue should be fixed in #90