search

Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.
GNU General Public License v2.0
108 stars 20 forks source link

Fix Error always block checkout when using WC Blocks #2684

Closed iyut closed 1 year ago

iyut commented 1 year ago

Description

Fixing a compatibility issue with WC Blocks where User cannot checkout because it always throw an error on checkout page that using WC Blocks. In this PR I remove the unneeded function and hooks. Because I dont see the point on having that hook and also removing the hook seems fixing the issue.

Related issue(s)

Fixes #2683

Steps to reproduce & screenshots/GIFs

  1. Enable WooCommerce. 2.Install/activate/configure WooCommerce Shipping & Tax to provide automated taxation.
  2. Automate the tax.
  3. Change the cart page and checkout page to use WooCommerce cart and checkout blocks.
  4. Try to make a purchase using the Checkout Block with any payment method (e.g. Check Payments)
  5. Use this address : Beverly Hills, California, US 90210. Then change the state from California to any other states.
  6. The zip code error will show : The provided postcode / ZIP is not valid.
  7. Change the state back to California, the error will not show and checkout will be submitted.

Checklist

ralucaStan commented 1 year ago

Is there anything that is blocking this PR from being merged? We have incoming reports of people being affected by this issue.

iyut commented 1 year ago

@samnajian , is that OK if we merge this PR with E2E tests failing? Or do you mind to review the fixes for E2e tests PR? Once E2E tests is approved and merged to trunk branch, then I can merge the trunk branch to this PR and merge this fixes.

iyut commented 1 year ago

Is there anything that is blocking this PR from being merged?

@ralucaStan , at the moment, we're blocked with the failed E2E tests. We will try to speed up this PR review and then merge this fix.

samnajian commented 1 year ago

@samnajian , is that OK if we merge this PR with E2E tests failing? Or do you mind to review the fixes for E2e tests https://github.com/Automattic/woocommerce-services/pull/2681? Once E2E tests is approved and merged to trunk branch, then I can merge the trunk branch to this PR and merge this fixes.

@iyut The e2e PR is approved, please rebase it into this branch before merging.