search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.44k stars 1.99k forks source link

eCommerce: My site drawer shows the wrong plan info #38499

Open alaczek opened 4 years ago

alaczek commented 4 years ago

When viewing the homepage of a site on eCommerce plan, the My Site button in the top left corner shows what looks like outdated version of the drawer, but I also noticed it says the site is on Free plan, when in fact it is on eCommerce plan (as reflected in Calypso).

Steps to reproduce

  1. Create a new site on an eCommerce plan.

  2. View the homepage of your new site.

  3. Click on My site in the top left corner - it says "Free" next to the plan. image

  4. Click on any of the links in the drawer to go to Calypso. It says "eCommerce" next to Plan. image

What I expected

For the correct plan info to be displayed in both places.

Context / Source

dogfooding, #manual-testing

timmyc commented 4 years ago

Confirmed this bug is still present.

I think the version of the masterbar in use here is from Jetpack, so I imagine this logic might be where to investigate this issue further.

lancewillett commented 4 years ago

Interesting find — the "hover" menu in masterbar is deprecated for Simple sites. Links now go directly to Calypso instead of showing the dropdowns.

For history's sake, it became too much work to maintain the separate menus, and removing them is the simplest solution.

timmyc commented 4 years ago

Interesting find — the "hover" menu in masterbar is deprecated for Simple sites.

@lancewillett so the hover menu should be removed from the JP masterbar then?

lancewillett commented 4 years ago

Yes, it should be removed everywhere now. Thanks for catching this.

davipontesblog commented 4 years ago

I suggest we remove this nav drawer from atomic sites as well, and simply redirect users to "My Home" when clicking on "My Site". Much better experience.

lancewillett commented 4 years ago

@davipontesblog +100 internal ref: pbAPfg-3G-p2

timmyc commented 4 years ago

I suggest we remove this nav drawer from atomic sites as well, and simply redirect users to "My Home" when clicking on "My Site". Much better experience.

I think the nav drawer on the AT sites is the Jetpack version - at least that is what my explorations led me to.

gwwar commented 4 years ago

@timmyc were you working on this?

timmyc commented 4 years ago

@gwwar - no I am not. I assign myself when I'm working on an issue - sorry if I gave the signal that I was working on this. Depending on how things go during our current cool down period, I'm hoping to carve some time to work on more ecomm issues logged here though.

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

obenland commented 3 years ago

I've put https://github.com/Automattic/wp-calypso/issues/50519 on the project board for Manage, which will remove the My Site drawer. We'll close this ticket once that's done. /cc @simison