Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Nav Unification: symlinked WooCommerce.com themes included on eCommerce plan not listed #50814

Open jartes opened 3 years ago

jartes commented 3 years ago

Steps to reproduce the behavior

  1. Create a new site and add an eCommerce plan.
  2. Go to Appereance → Themes → Add new theme
  3. Search for any Storefront Child Themes included in the eCommerce plan: Galleria, Homestore or, Bookshop.

What I expected to happen

Found any of the above themes in order to activate and use any.

What actually happened

The search didn't list any themes. They are only available when going directly to wp-admin/themes.php:

Markup on 2021-03-06 at 16:38:12

Browser / OS version

Chrome Version 88.0.4324.192 (Official Build) (x86_64) | Mac osX 11.2.1 (20D74)

Is this specific to the applied theme? Which one?

All of them.

Does this happen on simple or atomic sites or both?

Atomic sites with eCommerce plan.

Is there any console output or error text?

No

Level of impact (Does it block purchases? Does it affect more than just one site?)

It doesn't block purchases.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

See above.

mmtr commented 3 years ago

Yeah, this is because "Appearance > Add new theme" only list WP.org themes. See https://github.com/Automattic/jetpack/pull/18780.

@obenland @getdave should we rename the submenu to something else to avoid confusion?

jartes commented 3 years ago

Thanks for checking @mmtr! So, in this case, if a user wants to install a bundled theme from the eCommerce plan, we would direct them to wp-admin/themes.php? Thanks!

mrfoxtalbot commented 3 years ago

That's right @jartes, that will work as a workaround, but it will be next to impossible for a user to figure this out on their own.

obenland commented 3 years ago

"Browse Theme Directory"?

mrfoxtalbot commented 3 years ago

Not that this changes or fixes the main issue, but for just additional context, users will see the option to select one of these child themes during signup

Screenshot 2021-03-18 at 07 19 41

Here wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=theme

mrfoxtalbot commented 3 years ago

Related https://github.com/Automattic/wp-calypso/issues/52710

tjcafferkey commented 3 years ago

The issue here may be slightly alleviated when https://github.com/Automattic/wp-calypso/issues/51441 is completed and the user will be able to switch easily between Calypso & WP Admin.

jordesign commented 3 years ago

This issue is still in place - Storefront themes do not display in the Calypso theme showcase - only when viewing themes in WP Admin. Definitely still a low priority issue though.

dsas commented 2 years ago

It looks as though the themes page has been changed quite significantly since this was originally reported, Appereance → Themes → Add new theme no longer exists as a menu item, it's just Appearance → Themes

Installed themes such as the missing ones, are now available under 'My themes', so this issue seems like it's now been alleviated a fair bit. The themes are still not available under the other tabs though, just like manually installed themes are not.

image


The calypso themes view gets a list of themes allowed on wp.com via the API: WPCOM_JSON_API_Themes_v1_2_Endpoint ultimately this queries theme.wordpress.com for the allowed themes.

The calypso themes view also uses a separate WP.com API to get themes installed on the current site: WPCOM_JSON_API_List_Themes_Endpoint which does include this missing bunch.

The missing themes are benefits of the Ecommerce plan, so only should be available to people with that plan.. Adding the themes to the themes list as theme.wordpress.com would make them appear in the calypso themes list but they'd make them appear for everyone. Themes can belong to a tier - this is just free or premium, but perhaps we could add e-commerce as another tier, presumably we'd have to update calypso, WPCOM_JSON_API_Active_Theme_Endpoint and theme.wordpress.com to enable this but I've not had a detailed look.