Jetpack Search Setting: Disabling 'Enable Jetpack Search' doesn’t stick on simple sites

[kangzj]

Steps to reproduce the behavior

1. Open a wp.com simple site with Jetpack Search plan
2. Go to Settings -> General -> Performance
3. Click the toggle to disable Jetpack Search
4. Refresh the page

What I expected to happen

The toggle stays unchecked after reloading the page.

What actually happened

The toggle is still checked after reloading the page. It seems the option jetpack_search_enabled is not saved - the API returned okay when saving as false, but returning true on reloading.

Does this happen on simple or atomic sites or both?

Only on simple sites

Level of impact (Does it block purchases? Does it affect more than just one site?)

Low. If a user purchase Jetpack Search, the user would tend to use it rather than disabling it.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent

Screenshot / Video: If applicable, add screenshots to help explain your problem.

https://d.pr/i/aTQoHz

[kangzj]

 // public.api/rest/json-endpoints/class.wpcom-json-api-site-settings-endpoint.php:L344
&& $site->is_module_active( 'search' ); // always returns true for simple sites

It looks more of a business logic question than a bug.

[jsnmoon]

 // public.api/rest/json-endpoints/class.wpcom-json-api-site-settings-endpoint.php:L344
&& $site->is_module_active( 'search' ); // always returns true for simple sites

It looks more of a business logic question than a bug.

In that case, let's work on making our product messaging clearer.

Since all simple sites have the Search module active, does that mean we're providing Classic Search for all simple sites that have Instant Search disabled (either explicitly via Performance settings or by not having a Search subscription)? Does that mean they're on the older, less maintained search index?

Pinging @Automattic/pathfinder for more context/history on this issue.

[gibrown]

This should only come up if they have purchased a Search plan for a Simple site. I suspect this is a bug that probably never comes up because the solution would be to just turn off the product rather than disabling search. Maybe we should just gray out that option? Though I do wonder what happens if you have a WP.com business/ecommerce plan (which come with classic search) on a Simple site and you want to turn off search. Can you?