Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

Subscribers Page: Make `/subscribers` land in Calypso #77662

Closed ivan-ottinger closed 1 year ago

ivan-ottinger commented 1 year ago

Similarly as with the /subscriptions page before (pMz3w-haX-p2), we will likely need to request /subscribers to be pointed to Calypso as well.

At the moment, /subscribers lands in Calypso, but in the development environment only.

TimBroddin commented 1 year ago

@ivan-ottinger This would become https://wordpress.com/subscribers/<siteslug> right?

TimBroddin commented 1 year ago

@ivan-ottinger looking at the current paths I see routes such as /sites/<siteid>/subscribers/import. Wouldn't it be better to have our route be /sites/<siteid>/subscribers?

ivan-ottinger commented 1 year ago

@ivan-ottinger This would become https://wordpress.com/subscribers/ right?

Yes, that is where the currently developed page lives.

@ivan-ottinger looking at the current paths I see routes such as /sites//subscribers/import. Wouldn't it be better to have our route be /sites//subscribers?

🤔 What does load at /sites/<siteid>/subscribers/import for you? I am seeing just a blank screen there.

TimBroddin commented 1 year ago

@ivan-ottinger This would become https://wordpress.com/subscribers/ right?

Yes, that is where the currently developed page lives.

@ivan-ottinger looking at the current paths I see routes such as /sites//subscribers/import. Wouldn't it be better to have our route be /sites//subscribers?

🤔 What does load at /sites/<siteid>/subscribers/import for you? I am seeing just a blank screen there.

Nevermind, I was just OpenGrokking and wrongfully assumed something (it was an API call). Sorry for the confusion!

TimBroddin commented 1 year ago

Posted in systemrequests: pMz3w-hHc-p2

ivan-ottinger commented 1 year ago

No worries at all! Thank you for submitting the request, Tim!

ivan-ottinger commented 1 year ago

/subscribers is now loading nicely (with the feature flag enabled) in staging. 🙂