AvaloniaUI / Avalonia

Develop Desktop, Embedded, Mobile and WebAssembly apps with C# and XAML. The most popular .NET UI client technology
https://avaloniaui.net
MIT License
26.1k stars 2.26k forks source link

DataGrid selected row background is same as general selection color in 0.10-preview2 #4415

Open ShadowDancer opened 4 years ago

ShadowDancer commented 4 years ago

In version 0.10-preview2 selection color for DataGrid row is same as text selection color (so selected text in datagrid is not visible, this can be encountered even in avalonia explorer`. This happens only in SimpleTheme.

DataGrid uses HighlightColor. ListBox uses ThemeAccentColor4, so if TextBox is embedded selected text is visible, for DataGrid it is not.

image

maxkatz6 commented 4 years ago

It is probably related to https://github.com/AvaloniaUI/Avalonia/issues/4376

ShadowDancer commented 4 years ago

I think #4376 is about background for alternating rows, while this is about selection. But this background color is wrong too, for sure :)