AvraamMavridis / gulp-louis

Gulp task to analyze website performance.
36 stars 9 forks source link

gulp task doesnt complete with gulp4 #25

Closed rejas closed 6 years ago

rejas commented 6 years ago

Using the plugin like this:

// Check the performance budget
gulp.task('check:louis', () => {
    louis({
        performanceBudget: {
            domComplete: 3000,
            requests: 10
        }
    });
});

doesnt end the task correctly and I have to manually end it:

[16:41:25] Requiring external module babel-register
[16:41:27] Using gulpfile C:\Projekte\mine\homepage\gulpfile.babel.js
[16:41:27] Starting 'check:louis'...
[16:41:27] Starting server...
[16:41:28] Server started http://localhost:8888
[16:41:28] Running server

Metrics analyzed against performance budget

requests:  Expected < 10 Actual = 1
domComplete:  Expected < 3000 Actual = 14
[16:41:41] Server stopped
[16:41:41] The following tasks did not complete: check:louis
[16:41:41] Did you forget to signal async completion?
Batchvorgang abbrechen (J/N)?
rejas commented 6 years ago

hi @AvraamMavridis are you still maintaining this repo or can I somehow help you with this issue?

AvraamMavridis commented 6 years ago

@rejas Hi rejas, sure, feel free to submit MR, unfortunately no time right now to look on the issue myself.

rejas commented 6 years ago

PR done, what do you think?