search

AxaFrance / oidc-client

Light, Secure, Pure Javascript OIDC (Open ID Connect) Client. We provide also a REACT wrapper (compatible NextJS, etc.).
MIT License
582 stars 158 forks source link

oidc-client should be in dependencies and not peerDependencies #388

Closed guillaumechervetaxa closed 2 years ago

guillaumechervetaxa commented 4 years ago

When we install the lib the run crash because it does not install oidc-client. when we are doing npm i

we need to install oidc-client manually by: npm i oidc-client

guillaumechervetaxa commented 4 years ago

sample here https://github.com/AxaGuilDEv/react-toolkit/pull/508/files

guillaumechervetaxa commented 4 years ago

i have sthe same with recompose on react-oidc-context-fetch.

We should remove recompose dependency.

drwaky commented 4 years ago

Same here, I also have the same with "recompose" and "redux-oidc" on "react-oidc-redux".

guillaume-chervet commented 2 years ago

I think this issue has been fixed a long time ago. No problem in current v4. https://www.npmjs.com/package/@axa-fr/react-oidc-context