withAuthentication HOC triggers too many rerender of wrapped component

[JLou]

Issue and Steps to Reproduce

When using withAuthentication from @axa-fr/react-oidc-context-fetch, the component wrapped will rerender too many times.

In 3.1.6 with my reproduction code I get "toto 2", and in "3.1.7" I get "toto 6"

3.1.6:

3.1.7:

git clone https://github.com/JLou/repro-bug-react-oidc.git
cd repro-bug-react-oidc
npm i
npm start

Versions

3.1.7 & below

Screenshots

Expected

fetch should not change during the lifespan of the app, and should definitely not trigger a rerender of my wrapped component

Actual

it does

Additional Details

• Installed packages: "@axa-fr/react-oidc-context": "3.1.7", "@axa-fr/react-oidc-context-fetch": "3.1.7", "@axa-fr/react-oidc-core": "3.1.7", "@axa-fr/react-oidc-fetch-core": "3.1.7",

[guillaume-chervet]

The rerender problem is fixed in v4 by sliting hooks and by removing data duplication inside react.

[guillaume-chervet]

I close the issue, thank you for it. The v4 fixe it. Feel free to re-open an issue if you need it.