search

AykutSarac / jsoncrack.com

✨ Innovative and open-source visualization application that transforms various data formats, such as JSON, YAML, XML, CSV and more, into interactive graphs.
https://jsoncrack.com/
Other
30.5k stars 1.89k forks source link

Error: failed to download #150

Closed drvgautam closed 2 years ago

drvgautam commented 2 years ago

Issue description

While rendering a LARGE json file, it failed to download the rendered png image with an error message [failed to download]

Media & Screenshots

No response

Operating system

Priority this issue should have

Medium (should be fixed soon)

okch-codes commented 2 years ago

What do you mean by large? Is it something replicable?

AykutSarac commented 2 years ago

Can you share the sample?

harmeet-1337 commented 2 years ago

I also experienced same issue. I tried on firefox and chrome. Length of json is 3007.

drvgautam commented 2 years ago

Here's a sample file to reproduce the error. json_crack_failedDownload_sample_json.zip

okch-codes commented 2 years ago

I can't reproduce the bug on my PC. I suppose it's not properly a bug at this point. The application does client-side computation, this means that the machine resources required to produce an output are proportional to the input JSON you enter.

This is the output I got with the file you attached: jsoncrack com

I guess the code can be engineerized in some way. For this, I think this issue should be flagged as refactor more than bug.

AykutSarac commented 2 years ago

I've done some performance improvements could effect directly on this, however it mostly relies on your computer specs as paint is made on the DOM.