search

Azelphur / SourceIRC

An easy to use SourcePawn API to the IRC protocol.
6 stars 9 forks source link

Small changes to relayall #5

Closed DJPlaya closed 7 years ago

DJPlaya commented 7 years ago

|-sourceirc-relayall.sp |Dis-/Connect Messages and Mapchanges are now broadcasted to Channels marked with "detail" |Messages and Namechanges are broadcasted to Channels marked with "relay" |Cleaned up the Code

|-sourceirc.cfg |Added Example for "detail" messaging mark |Updated Ticketreasons

Azelphur commented 7 years ago

Hi,

Thanks for contributing to SourceIRC, There's a few changes that'd need to be made before I could accept this into core.

I'm a big fan of keeping existing installations working normally through updates. This change would require users to add an extra config setting to have SourceIRC continue to work as it once did. I think it'd be better if you added some settings to the "relay" config to surpress certain messages, for example the config could look like this:

"relay": "no-joins,no-disconnects,no-mapchanges"

This would make it even more configurable, and not break existing installations.

Feel free to comment if you can think of something even better, or if you have any questions about how you'd do that.

Apart from this, you've added a lot of new ticket menu items, a lot of which are specific to Counter Strike. SourceIRC works on all games that SourceMod supports - not just Counter Strike. So adding things like "Team Flashing" doesn't apply to a lot of users. I think the default list is an ample example which can be configured if need be.

Your commit seems to delete and recreate the entire sourceirc-relay.sp file - not sure why. But at first glance I can see that you've replaced the IRC_VERSION variable and removed the url from myinfo, not sure why you've done that.

As for your edit to the author string, I'm guessing you want attribution, but the author field on myinfo isn't the best place to do that (otherwise we'll end up with an author string 4 miles long). Github has a list of contributors, and I'm open to the idea of adding a CONTRIBUTORS file if you like.

DJPlaya commented 7 years ago

Arr, sry ime new to this Git Stuff. Just wanted to share a Version that would allow a Server-Crosschat without Spam. I will propably work on a System relaying messages when someone is mentioned

Azelphur commented 7 years ago

Sure, I'm going to go ahead and close this now then, feel free to reopen if you decide to work on this more and get it into the SourceIRC release :)

You can always message me here or on IRC (I'm in #sourcemod) if you have any questions :)