search

Azgaar / Armoria

Heraldry generator and editor
https://azgaar.github.io/Armoria
280 stars 30 forks source link

Support patterns for charges and ordinaries #175

Closed Blipz closed 3 months ago

Blipz commented 4 months ago

Even though the backend supported it, there was no UI for patterned charges and ordinaries.

With this PR, patterns and semies can now be selected to color ordinaries and charges (including secondary and tertiary coloring).

Note 1: the default probability of patterned charges/ordinaries has not been modified here (so still at 0). Also, maybe the chance system should differentiate between charges and ordinaries.

Note 2: the UI could probably be improved in some way. With both multicolor and pattern support, coloring a charge might become confusing to users.

Azgaar commented 4 months ago

Can you please add a description on what is actually does? It's not 100% clear. Maybe can reuse some description from https://github.com/Azgaar/Armoria/discussions/174

Blipz commented 4 months ago

Yes, I'll reword the commit (it's not directly related to #174).

Azgaar commented 3 months ago

Is it ready for merging?

Blipz commented 3 months ago

Is it ready for merging?

Yes. UI could be improved later if needed.

Azgaar commented 3 months ago

Ok, let's merge.