search

AzimoLabs / fastlane-plugin-automated-test-emulator-run

Plugin dedicated for Android platform. Wraps gradle task/shell command used for launching instrumented tests. Provides start of as many AVDs with various configs as needed before test run, waits for boot, kills emulators and deletes them from hdd after tests are finished or disturbed.
MIT License
112 stars 48 forks source link

Add option to skip reset adb #5

Closed OSemenovBoyarka closed 7 years ago

OSemenovBoyarka commented 7 years ago

Thanks for great plugin!

In our setup - we run tests for couple different projects on single build machine with Jenkins.

Issue is, plugin restarts adb, because of code here https://github.com/AzimoLabs/fastlane-plugin-automated-test-emulator-run/blob/master/lib/fastlane/plugin/automated_test_emulator_run/actions/automated_test_emulator_run_action.rb#L74

Restarting adb, while other test run in progress, causes that test run to fail.

It would be really nice, to be able disable that adb restart via config option.

FisherKK commented 7 years ago

Hello!

I have added 'ADB_restart' parameter for you. Set it to false and ADB won't restart anymore.

https://github.com/AzimoLabs/fastlane-plugin-automated-test-emulator-run/blob/master/lib/fastlane/plugin/automated_test_emulator_run/actions/automated_test_emulator_run_action.rb#L316

Thank you for using our plugin :)

OSemenovBoyarka commented 7 years ago

Thanks for quick fix, now it works like a charm for me!