gitclaim example uses a local zkemail.nr reference

microbecode commented 1 month ago

Issue Description

The https://github.com/saleel/gitclaim example project uses a local reference in Nargo.toml for zkemail.nr . That doesn't come automatically when you download the project and needs to be setup manually.

Project Context

Name: Invite only

Challenge: ZKEmail Guardian

GitHub Repository: https://github.com/microbecode/zk-invite-only

Environment

Aztec Version: 0.57.0 sandbox

Noir Version (if applicable): 0.54

Operating System: Ubuntu

Steps to Reproduce

Download the gitclaim project
Try to compile
The local reference doesn't exist

Expected Behavior

What did you expect to happen? Successful compilation

Actual Behavior

What actually happened? errors

Code Snippet

sh build.sh

Error Messages

Additional Context

Possible Solution

Change the nargo.toml to point to online reference. For example:

zkemail = { tag = "v0.3.0", git = "https://github.com/zkemail/zkemail.nr", directory = "lib" }

Impact on Development

Support Needed

critesjosh commented 4 weeks ago

Does using this work for you?

zkemail = { tag = "v0.3.0", git = "https://github.com/zkemail/zkemail.nr", directory = "lib" }

microbecode commented 4 weeks ago

Isn't that the same as in the issue's "possible solution"? Yes, that's a solution

AztecProtocol / ab2