search

AztecProtocol / aztec-packages

Apache License 2.0
199 stars 224 forks source link

`yarn install` fails in `<repo>/yarn-project` #7510

Open smanilov opened 3 months ago

smanilov commented 3 months ago

Checking out a clean clone of the repo and running yarn install in the yarn-project subdir fails with the following error:

➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @noir-lang/acvm_js@portal:../noir/packages/acvm_js::locator=%40aztec%2Faztec3-packages%40workspace%3A.: Manifest not found
    at zA.find (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:390:32033)
    at async /home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:610:3506
    at async Object.a0e (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:390:10980)
    at async zb.resolve (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:610:3467)
    at async kf.resolve (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:391:1400)
    at async kf.resolve (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:391:1400)
    at async /home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:439:6681
    at async df (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:390:11064)
    at async _ (/home/stan/code/repos/aztec-packages/yarn-project/.yarn/releases/yarn-3.6.3.cjs:439:6663)
➤ YN0000: └ Completed in 0s 205ms
➤ YN0000: Failed with errors in 0s 207ms

This is on commit 2a5ee4f4a5a31ba1582dceecee0a3d79a0ac31d2.

Also tested on aztec-package-v0.45.1 and the error is the same.

Also tested on commit 400c6de587567222885643f534e48a472edfe8b5, where the README.md has been added in that dir, and yarn install succeeds!

So we went on to "bisect" manually, and got the following results:

tag status
v0.45.1 failure
v0.44.0 failure
v0.40.0 failure
v0.30.0 failure
v0.20.0 failure
v0.19.0 failure
v0.18.0 failure
v0.17.0 failure
v0.16.0 failure
v0.15.0 success
v0.10.0 success

Commit 400c6de587567222885643f534e48a472edfe8b5 (mentioned before) is before v0.1.0, it seems.

So it seems that somewhere between v0.15.0 and v0.16.0 yarn install stopped working.

The question is: are we doing something wrong, or is this reproducible for others too?

smanilov commented 3 months ago

Update: also tried to reproduce this in a clean slate docker image of ubuntu and succeeded to reproduce.

Any thoughts?

FilipHarald commented 2 months ago

I got almost the same error* both locally and on a fresh install of https://github.com/AztecProtocol/aztec-packages/tree/master/build-images#build-image

*

Error: @noir-lang/noir_codegen@portal:../noir/packages/noir_codegen::locator=%40aztec%2Faztec3-packages%40workspace%3A.: Manifest not found
critesjosh commented 1 week ago

Can you try running ./bootstrap.sh fast in the root of the monorepo now? This should fetch the latest builds from the cache and the build yarn project.