Azure-Samples / communication-services-ios-quickstarts

Sample code for Azure Communication Services iOS quickstarts
MIT License
11 stars 24 forks source link

FixSampleAppToImproveNotificationDelivery #74

Closed angellan-msft closed 6 months ago

angellan-msft commented 6 months ago

Purpose

This PR introduces the updates to enhance the user experience of the notification system in our Chat SDK. Specifically, we've made two changes:

1.Centralized Content Handler Call: We've moved the contentHandler call to ensure it's executed in all execution paths, addressing an issue where customized notifications could fail to deliver. Also it can reduce the delay time of notification delivery.

2.Fallback Notification Content: Introduced default notification content ("New Message" and "Please tap here to see the message.") to ensure a fallback message is always available, improving the user experience in error scenarios or unexpected data formats.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

We've already tested the fix using an IOS device.

What to Check

Verify that the following are valid

Other Information