Azure-Samples / modern-data-warehouse-dataops

DataOps for the Modern Data Warehouse on Microsoft Azure. https://aka.ms/mdw-dataops.

MIT License

570 stars 451 forks source link

Issue/390/deploy wheel packages and requirements to synapse #433

Closed shervyna closed 2 years ago

shervyna commented 2 years ago

Type of PR

Code changes
CI-CD changes

Purpose

This PR deploys wheel packages and requirement.txt to synapse. This PR also assigns the sp used by the service connection to be granted synapse RBAC.

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[X] No PII in logs
[ ] Made corresponding changes to the documentation

Issues Closed or Referenced

Closes #390

shervyna commented 2 years ago

Please have discussion with Jason about you two's PR for some of duplication work :)

Exactly, @jmostella you basically finished my task lol I checked the board and I think your task was supposed to be CI?

jmostella commented 2 years ago

Please have discussion with Jason about you two's PR for some of duplication work :)

Exactly, @jmostella you basically finished my task lol I checked the board and I think your task was supposed to be CI?

That's correct. I think since some of my changes are out of scope, you can merge these changes, and I can rebase