[Module Proposal]: `avm-ptn-avd-lza-sessionhosts` (tf)

[cshea-msft]

Check for previous/existing GitHub issues/module proposals

• [x] I have checked for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

• [X] I have checked for that this module doesn't already exist in CARML or TFVM

Terraform or Bicep?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-avd-lza-sessionhosts

Module Details

Creating an AVD Session Host with Azure Entra ID join module, that will deploy session hosts into a host pool. Jen Sheerin is working on the host pool module that will be used to add the session hosts too. Eventually will add this to the pattern module for AVD LZA.

code is currently in https://github.com/Azure/avdaccelerator/blob/main/workload/terraform/greenfield/AADscenario/host.tf

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username

cshea15, jensheerin

[matebarabas]

Aiming for consistency between the Bicep and Terraform version of the AVD resource modules as well as the pattern module of the AVD LZA, before moving on with this issue, @danycontre and @moisesjgomez will align internally with @jensheerin on the composition of the modules and other technical questions. CC: @cshea15

[cshea-msft]

thanks @matebarabas will do!

[cshea-msft]

@matebarabas after discussing with others, we will move this to a Pattern Module and not a resource module. I did make the edit to the proposal. Please let me know if there is anything else you need from me. thanks!

[cshea-msft]

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

[jensheerin]

@matebarabas Met with Matt White and reviewed all of the AVD tf module proposals and he approves moving to in development

[matebarabas]

@jensheerin, thanks for opening this request and volunteering! Thanks for aligning with @matt-FFFFFF, @danycontre, @moisesjgomez and others.

I know Charles has already pasted the confirmation statement above, but since you indicated you'd be the primary owner, I'd like to ask you to do confirm ownership.

Thank you!

[matebarabas]

Hi @jensheerin,

Thanks for requesting/proposing to be an AVM module owner.

We just want to confirm you agree to the below pages that define what module ownership means:

• https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
• https://azure.github.io/Azure-Verified-Modules/specs/shared
• https://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed, let us know.

If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

[jensheerin]

"CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

[matebarabas]

Hi @jensheerin,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities.

We just want to ask you to double check a few important things before you start the development.

Please visit the module index page of your module and use the following values explicitly as provided there:

• ModuleName
• TelemetryIdPrefix
• ModuleOwnersGHTeam and ModuleContributorsGHTeam
• Repository name and folder path defined in RepoURL

You can now start the development of this module! Happy coding! 🎉

Please respond to this comment, once your module is ready to be published!

Any further questions or clarifications needed, let us know.

Thanks,

The AVM Core Team

[jensheerin]

Module in progress

[jensheerin]

CELA approval completed https://dev.azure.com/ossmsft/Reviews/_workitems/edit/49287?src=WorkItemMention&src-action=artifact_link

[mbilalamjad]

Reached out to @jensheerin offline to confirm any updates or any supported need, she or I will update accordingly.

[jensheerin]

@matebarabas can the assignee be changed to @cshea-msft please? Charles is working on this ptn module. Thank you!

[mbilalamjad]

@matebarabas can the assignee be changed to @cshea-msft please? Charles is working on this ptn module. Thank you!

Sure Done

[matebarabas]

I've just noticed that Charles's GH handle in use here is not the same that was originally noted down in the issue description above. I've updated this in the module indexes, which will go live at the next index update.

[matebarabas]

@jensheerin can you please also make sure that @cshea-msft is added to the related -owners team? Thanks!

[mbilalamjad]

CELA approval completed https://dev.azure.com/ossmsft/Reviews/_workitems/edit/49287?src=WorkItemMention&src-action=artifact_link

@cshea-msft, @jensheerin this cela review is for avm-ptn-avd-lza-insights as you are noting it on the related issue, has one been done for avm-ptn-avd-lza-sessionhosts and is the repo setup now?

[cshea-msft]

Still a work in progress

[cshea-msft]

@matebarabas @mbilalamjad - I know this has been open for a while, I think it might be best to make this an example in @jensheerin's avd management pattern since it relies on those modules. This pattern doesnt create anything new, it uses VMs to create the Session host.

Wanted to get your thoughts about closing this and making this more of an example in another pattern?

thanks,

[matebarabas]

@cshea-msft, thank you for being proactive on this! As this proposal (along with 2 other related ones) has been opened as part of @danycontre's and @moisesjgomez's efforts on the AVD LZA, I recommend consulting them on how to continue the work on this module.

Also, please note that even though the 4 equivalent pattern modules in Bicep have been de-prioritized by them timeline-wise, it was eventually decided to keep those open, as at one point their development should commence.

When you sync with Dany and Moises, please involve Jen and make sure the decision (whatever it ends up being) is captured for the Bicep equivalent module(s) too. Thank you!

[cshea-msft]

@matebarabas can we mark this as the same as the bicep pattern module? the AVD LZ Terraform is using resource modules and not using the pattern modules. confirmed with @danycontre they are keeping to pattern logic on LZA for now.

cc @jensheerin

[matebarabas]

@cshea-msft, sure thing! I just marked this one as long-term as well, so that it can stay here indefinitely - until a decision is made about either picking it up again for development or abandoning it. Thanks.

CC: @PmeshramPM, @mbilalamjad, @prjelesi

[florian-ried]

@matebarabas

I’m very interested in understanding how this will move forward. I wanted to check in on the current status and future steps regarding the development of a avm module specifically for deploying AVD session hosts. Currently, the pattern module avm-ptn-avd-lza-managementplane provides a comprehensive setup of AVD resources, yet does not facilitate the rollout and host pool registration of session hosts.

Could you clarify if a module dedicated to AVD session hosts is planned? It would be fantastic if the AVM framework could fully support AVD deployment. The existing code in the AVD Accelerator is already highly functional, so integrating session host deployment into AVM would be a great addition.

Thanks for the update!

Best, Florian

[matebarabas]

@cshea-msft, @jensheerin, @moisesjgomez, @danycontre, can you please comment on the above question of @florian-ried? Thanks!

@florian-ried, is it safe to assume that the scope of your question is Terraform?

[florian-ried]

@cshea-msft, @jensheerin, @moisesjgomez, @danycontre, can you please comment on the above question of @florian-ried? Thanks!

@florian-ried, is it safe to assume that the scope of your question is Terraform?

Correct, scope is Terraform 😊

[jensheerin]

@florian-ried Thank you for raising this issue! The pattern module avm-ptn-avd-lza-managementplane example was recently updated to include a session host until we finalize the direction of the sessionhosts module. See https://github.com/Azure/terraform-azurerm-avm-ptn-avd-lza-managementplane/blob/main/examples/default/README.md

cc: @cshea-msft @matebarabas @moisesjgomez @danycontre