search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
282 stars 61 forks source link

[Module Proposal]: avm-ptn-finopstoolkit-finopshub #983

Open didayal-msft opened 1 month ago

didayal-msft commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-finopstoolkit-finopshub

Module Details

Terraform module for FinOps toolkit's hub. Details here: https://microsoft.github.io/finops-toolkit/hubs/template

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

didayal-msft

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

prjelesi commented 1 month ago

@didayal-msft can you provide confirmation from FonOps toolkit team that you will drive this development in their name?

prjelesi commented 1 month ago

This will be on hold until we get confirmation from FinOps toolkit team. @flanakin for visibility.

didayal-msft commented 1 month ago

Yes @prjelesi this needs to be on hold as per last week's discussion. We will wait for bicep pattern module and see demand as well as review overhead of managing 2 modules. For now this can be put on hold or closed as per procedure.

flanakin commented 1 month ago

I believe @sebassem is already working on this 🙂

sebassem commented 1 month ago

We already published this module :)

https://github.com/Azure/bicep-registry-modules/tree/main/avm/ptn/finops-toolkit/finops-hub

prjelesi commented 3 weeks ago

@sebassem as i can see you published bicep module, this is request for terraform. @flanakin @didayal-msft

prjelesi commented 2 weeks ago

Since we agreed to proceed with this:

Hi @didayal-msft

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

didayal-msft commented 2 weeks ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

prjelesi commented 1 week ago

Hi @didayal-msft

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team