Wording Improvements for Unique ID GitHub Action - Githubissues

Azure / Community-Policy

This repo is for Microsoft Azure customers and Microsoft teams to collaborate in making custom policies.

MIT License

623 stars 323 forks source link

Wording Improvements for Unique ID GitHub Action #477

Open Joshua-Donovan opened 2 weeks ago

Joshua-Donovan commented 2 weeks ago

The last improvement to switch sources to check policy ids has introduced existing Community Policies that can be validated.

Issue:

Community Policies will be caught by the unique id check and be mislabeled in the error as a built-in.

Improvement:

Identify a distinction in the check and output a different error for Community and built-in Azure Policy Definitions to avoid confusion.

(optional) improviement:

Try to identify a way to provide a link to the existing Azure Policy Definition that was matched in the output.

https://github.com/Azure/Community-Policy/blob/135c10c12de0a14c8a54e437862554ffcd6f9a90/.github/workflows/confirm-policy-definition-no-built-in-conflicts.yaml#L180-L209

Joshua-Donovan commented 2 weeks ago

Additionally, Landing Zone policies exist in the data source so we will need to account for those as well.