chore: Update Deploy-ASC-SecurityContacts version to 2.0.0

Springstone commented 3 months ago

Overview/Summary

This pull request primarily focuses on updating the Deploy-ASC-SecurityContacts.json policy definition in the src/resources/Microsoft.Authorization/ directory. The key updates include upgrading the version of the policy, modifying the description of the "Security contacts email address" metadata, updating the security contact fields, and changing the API version.

Policy Definition Updates:

src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The policy version was updated from "1.1.0" to "2.0.0". This suggests a significant update or change in the policy.

Metadata Changes:

src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The description for the "Security contacts email address" metadata was changed. It now indicates that multiple email addresses separated by semi-colons can be provided for Defender for Cloud contact details.

Security Contact Fields:

src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: Several fields related to security contacts were modified. The alertNotifications.minimalSeverity and alertsToAdmins fields were removed, while the isEnabled and notificationsSources[*].Alert.minimalSeverity fields were added. This indicates a shift in how security contacts and alert notifications are managed.

API Version Change:

src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The API version was updated from "2020-01-01-preview" to "2023-12-01-preview". Additionally, the alertNotifications property was replaced by notificationsSources, and a new isEnable property was added. These changes suggest a significant update to the API and how notifications are handled.

This PR fixes/adds/changes/removes

Replace me

Testing URLs

Azure Public

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Ensured contribution guidance is followed.
[x] Updated relevant and associated documentation.
[x] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

jtracey93 commented 3 months ago

@donk-msft I cannot see the comments on this PR you mention here: https://github.com/Azure/Enterprise-Scale/issues/1627#issuecomment-2154349705

Can you advise as looking to get this out 👍

donk-msft commented 3 months ago

@donk-msft I cannot see the comments on this PR you mention here: #1627 (comment)

Can you advise as looking to get this out 👍

@jtracey93 comments have been addressed by @Springstone in the meantime. No open comments left from my side.

Azure / Enterprise-Scale