Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
32 stars 23 forks source link

Adding support for LoadBalancerSourceRanges #293

Open amargherio opened 1 month ago

amargherio commented 1 month ago

Description

This PR adds in support for LoadBalancerSourceRanges as part of the NginxIngressController CRD. I was looking through potential issues to take a shot at implementing and the idea of LoadBalancerSourceRanges seemed well-scoped enough to take on and added some practical functionality that I've depended on in the past.

If there's anything I've overlooked while working through this feature implementation, let me know and I'll work to get it resolved.

Feature #263

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Test cases added to unit tests covering extra attributes on the CRD object. I've also built out a dev environment following the local testing guide and functionally tested the deployment in that environment. I'm looking to add an additional case or cases to the E2E as well.

When I had to regenerate the CRD manifests and the generated code, I did have to bump the controller-gen version from 0.13.0 to 0.16.3 because of null pointer derefs when using Go 1.22 (https://github.com/kubernetes-sigs/controller-tools/issues/880). I'm happy to downgrade my Go install to a 0.13.0 compatible version if required to maintain consistency with the controller-gen version used previously.

Checklist:

amargherio commented 1 month ago

@microsoft-github-policy-service agree company="Microsoft"

amargherio commented 1 month ago

Bumping for review

amargherio commented 1 month ago

Bumping again for a potential review - tagging @OliverMKing

amargherio commented 2 weeks ago

Bumping for review