This PR adds in support for LoadBalancerSourceRanges as part of the NginxIngressController CRD. I was looking through potential issues to take a shot at implementing and the idea of LoadBalancerSourceRanges seemed well-scoped enough to take on and added some practical functionality that I've depended on in the past.
If there's anything I've overlooked while working through this feature implementation, let me know and I'll work to get it resolved.
Feature #263
Type of change
Please delete options that are not relevant.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Test cases added to unit tests covering extra attributes on the CRD object. I've also built out a dev environment following the local testing guide and functionally tested the deployment in that environment. I'm looking to add an additional case or cases to the E2E as well.
When I had to regenerate the CRD manifests and the generated code, I did have to bump the controller-gen version from 0.13.0 to 0.16.3 because of null pointer derefs when using Go 1.22 (https://github.com/kubernetes-sigs/controller-tools/issues/880). I'm happy to downgrade my Go install to a 0.13.0 compatible version if required to maintain consistency with the controller-gen version used previously.
Checklist:
[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
This PR adds in support for LoadBalancerSourceRanges as part of the
NginxIngressController
CRD. I was looking through potential issues to take a shot at implementing and the idea of LoadBalancerSourceRanges seemed well-scoped enough to take on and added some practical functionality that I've depended on in the past.If there's anything I've overlooked while working through this feature implementation, let me know and I'll work to get it resolved.
Feature #263
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test cases added to unit tests covering extra attributes on the CRD object. I've also built out a dev environment following the local testing guide and functionally tested the deployment in that environment. I'm looking to add an additional case or cases to the E2E as well.
When I had to regenerate the CRD manifests and the generated code, I did have to bump the controller-gen version from 0.13.0 to 0.16.3 because of null pointer derefs when using Go 1.22 (https://github.com/kubernetes-sigs/controller-tools/issues/880). I'm happy to downgrade my Go install to a 0.13.0 compatible version if required to maintain consistency with the controller-gen version used previously.
Checklist: