added wrapper around build container

[OliverMKing]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

• [ ] Test A
• [ ] Test B

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[OliverMKing]

@Tatsinnit any ideas on a better way to do this? The extension we are interfacing with doesn't return anything with the executeCommand function. This is extremely hacky but the only workaround unless we submit a PR into that repo (which we will probably want to do sometime). this is just a temporary workaround for demo.

[Tatsinnit]

@Tatsinnit any ideas on a better way to do this? The extension we are interfacing with doesn't return anything with the executeCommand function. This is extremely hacky but the only workaround unless we submit a PR into that repo (which we will probably want to do sometime). this is just a temporary workaround for demo.

☕️☕️ Cool, It is indeed, very interesting. Here are 2 options, It is absolutely normal for many extension co-exist but as long as its well thought as a user scenario. (Otherwise we could land in cross copy/paste code or hard to maintain features)

2 ways possibly could be:

• Option 1: Let vscode-docker extension experience take over after exec call - Communicating directly with the extension command: (Let the run experience of the vscode-docker take over and don’t try and tenable the promise and handle separately. (Again I have no idea what this scenario is)
  • you can first do a getExtension() api check for the extension name publisher.name aka ms-azuretools.vscode-docker from package.json metadata of the docker extension.
  • Then check for activate() is important to make sure you have the extension object.
  • Once activation is true then: Invoke the command you want to execute.
  • Error handle and let the other extension take over the experience.
• For example Kuberentes extension and AKS extension has couple of cross shared commands.
• Option 2: Tricky but long shot - Use of pacakge.json -- When clause and just hook the command directly on the command of other dependent extension in this case docker extension .

Other user option: Otherwise let the docker extension take over the whole scenario, just let them invoke the docker command.

fyi @bfoley13, @qpetraroia, @sabbour just for keeping this as fyi when proper delivery for specific aspect will happen. ❤️☕️

Thanks,