Azure / azure-functions-kafka-extension

Kafka extension for Azure Functions
MIT License
114 stars 81 forks source link

Should review serialisation #36

Open fbeltrao opened 5 years ago

fbeltrao commented 5 years ago

Currently we support built-in serialisation for avro and protobuf. Avro relies on Confluent.Kafka. Protobuf relies on google.protobuf.

Having serialisation built-in has the following advantages:

Disadvantages:

ryancrawcour commented 5 years ago

@jeffhollan what's your take on this? Do you see an issue with depending on specific libraries like Avro andor Protobuf for developers trying to build functions? Should we somehow allow developers to bring their own serializer?

jeffhollan commented 5 years ago

I'm personally fine with the behavior of having it built in. The biggest question I have is on schema. I don't know if Avro and Protobuf require it but I know usually you read as a specific "type", and I don't know how a JavaScript user could provide their .proto metadata to enable it. But maybe it's like JSON and we can read as a generic "JObject-like" thing and it's not a big deal. Any thoughts on if more is required than just a switch between "raw | protobuf | Avro" ?