Feature: watch mode - Githubissues

Azure / azure-functions-pack

Easily package your Node.js Functions for Azure Functions

MIT License

153 stars 31 forks source link

Feature: watch mode #59

Closed matthewmeyer closed 6 years ago

matthewmeyer commented 6 years ago

Adding a watch mode option for better interop with func host
Cleaned up the WebPack file manipulation slightly to involve less file copies and deletes
Added 2 lint ignores for failed linting on arrow function parens with async keyword

dnfclas commented 6 years ago

All CLA requirements met.

luismanuel001 commented 6 years ago

any updates?

matthewmeyer commented 6 years ago

The continuous-integration failed for a unrelated reason, I submitted a separate PR #61 which fixes the CI. How do I re-trigger the CI?

christopheranderson commented 6 years ago

CI works :)

christopheranderson commented 6 years ago

Looks good from just eye balling it. I think my only concern at this point is that there are no tests. Is that something you feel like you can take a stab at?

christopheranderson commented 6 years ago

Also need to update the readme

christopheranderson commented 6 years ago

Just a heads up, I've got an upstream chance I want to get into dev soon: https://github.com/Azure/azure-functions-pack/tree/feature/publish-directory

I think we'll conflict with each other, but if I'm overly eager, I'll just merge this as is, address the merge conflicts on my end and then poke you for the other changes in a separate PR.

matthewmeyer commented 6 years ago

I'll get some tests this week, hopefully before Thursday.

christopheranderson commented 6 years ago

Hey I'm just gonna merge this via #67 where I addressed the merge conflicts. You can send another PR with tests.

christopheranderson commented 6 years ago

Send a new PR for the tests. Closing this since I've merge it in #67 now.

matthewmeyer commented 6 years ago

I'm a little slow on the tests because I found a bug in WebPack that I needed to work around. The watcher was firing repeatedly for the first 10 seconds. That's the point of testing I guess. I have to switch back to a work feature so I expect to have it done over the weekend or early next week.