Azure / azure-kusto-java

Microsoft Azure Kusto Library for Java
MIT License
38 stars 43 forks source link

ignore first record support #304

Closed ronmonetaMicro closed 1 year ago

ronmonetaMicro commented 1 year ago

Added

github-actions[bot] commented 1 year ago

Test Results

255 tests  ±0   250 :heavy_check_mark: +1   3m 52s :stopwatch: - 2m 53s   21 suites ±0       5 :zzz: ±0    21 files   ±0       0 :x:  - 1 

Results for commit 01e006da. ± Comparison against base commit 7c2a1416.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #304 (49a5590) into master (82c2710) will increase coverage by 0.15%. The diff coverage is 70.58%.

:exclamation: Current head 49a5590 differs from pull request most recent head 01e006d. Consider uploading reports for the commit 01e006d to get more accurate results

@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
+ Coverage     55.71%   55.86%   +0.15%     
- Complexity      652      653       +1     
============================================
  Files           101      101              
  Lines          3579     3564      -15     
  Branches        382      376       -6     
============================================
- Hits           1994     1991       -3     
+ Misses         1421     1409      -12     
  Partials        164      164              
Impacted Files Coverage Δ
...ure/kusto/ingest/ManagedStreamingIngestClient.java 65.49% <70.58%> (+4.34%) :arrow_up:
AsafMah commented 1 year ago

So seems like ignoreFirst record was already there?

Just fix the comment and you can merge