Azure / azure-remote-rendering

SDK and samples for Azure Remote Rendering
MIT License
107 stars 39 forks source link

Added a comment that require IAM configuration to Azure Blob Storage #39

Closed hiroakit closed 3 years ago

hiroakit commented 3 years ago

This is a feedback.

Reason:

I tried to run the ShowCase unity project in Unity while reading the following documents:

  1. https://docs.microsoft.com/en-us/azure/remote-rendering/samples/showcase-app
  2. https://docs.microsoft.com/en-us/azure/remote-rendering/quickstarts/convert-model

However, I didn't realize that IAM settings required in Azure Storage, and several hours passed... On the other hand, searching carefully in docs.microsoft.com, we will find the corresponding description page:

Therefore, I thought it would make the introduction smoother and save time to have the URL around RemoteObject.cs L: 691.

FlorianBorn71 commented 3 years ago

Hi, quick update here: To be less specific about the storage type, we decided to do the following:

That way we have an extra indirection that allows us to add more troubleshooting guides in the future to the docs.

FlorianBorn71 commented 3 years ago

That said, you can abandon this PR, because our change will be deployed to this repo with the next release. Thanks for all your contributions, it's always very welcome!

hiroakit commented 3 years ago

Hi, Florian. Thank you for your kind reply. The plan is so cool, then I closed this PR.