Open heaths opened 2 years ago
@rokulka FYI. Are the transforms needed for PATCH calls and done for SDK as per guidelines? @heaths I do not see the need for x-ms-pageable for above mentioned APIs. UpdateQnas or UpdateSources does not return any response that will need to be paginated. It is just a 202 on success with operation-location in header. Subsequent status polling is done using the job id in the header.
x-ms-pageable
is needed for the final result, which is a 200 on the original URI. This impacts how LROs are generated for the SDK and is not pure swagger (hence being an extension for autorest). Without this or transforms - which then every SDK language has to do - SDKs will not include a pageable result when the LRO completes.
There's a few LROs that are meant to return pageable results once complete - the original URI - and should be defined as such per https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-pageable.
These include, but may not be limited to:
For now in the SDK, we are using transforms but these changes should be in the swagger initially. For reference: