search

Azure / azure-sdk-for-cpp

This repository is for active development of the Azure SDK for C++. For consumers of the SDK we recommend visiting our versioned developer docs at https://azure.github.io/azure-sdk-for-cpp.
MIT License
177 stars 126 forks source link

Move UserAgentGenerator to internal and simplify scenario. #6148

Closed ahsonkhan closed 1 month ago

ahsonkhan commented 1 month ago

Related to https://github.com/Azure/azure-sdk-for-cpp/pull/6067 and https://github.com/Azure/azure-sdk-for-cpp/pull/5662

1) Fixes issue on Windows/MSVC where the value of __cplusplus doesn't update (this only fixes SDK source, since that's where our compile options are used). Previously, on MSVC, we'd be getting skewed results with value 199711L. https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170 2) Rather than having friend classes, and different telemetry values for samples/tests/SDK sources, use the same __cplusplus value across the board 3) TODO: Cleanup unnecessary compile definitions within CMakeLists.txt after offline discussion on whether there is enough value for that differentiation for it to be worth the cost. We could evaluate other alternatives to differentiate between end customer usage and SDK/CI builds.

azure-sdk commented 1 month ago

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core-cpp azure-messaging-eventhubs-cpp

ahsonkhan commented 1 month ago

Closing this in favor of https://github.com/Azure/azure-sdk-for-cpp/pull/6067

We discussed offline, and landed on keeping the compiler_definitions and ifdef to see what type of data we get, before revisiting the simplification.