search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.09k stars 1.21k forks source link

[Digital Twins - Core] DigitalTwins Models - create, read, list, delete operations create models empty failing in nightly runs #22086

Closed v-jiaodi closed 2 years ago

v-jiaodi commented 2 years ago

Digital Twins - Core nightly test runs are failing with:

Error message: expected 'Operation failed as models provided w…' to include 'should satisfy the constraint "MinIte…'

Stack trace: AssertionError: expected 'Operation failed as models provided w…' to include 'should satisfy the constraint "MinIte…' at Context. (/Users/runner/work/1/s/sdk/digitaltwins/digital-twins-core/test/public/testModels.spec.ts:105:14) at runMicrotasks () at processTicksAndRejections (node:internal/process/task_queues:96:5)

For more details check here:

johngallardo commented 2 years ago

@abhinav-ghai, can you please have a look?

jeremymeng commented 2 years ago

Could be related to PR #22029 where client side constraint validation was removed.

abhinav-ghai commented 2 years ago

We've identified a issue on service side. We'll be rolling out a hotfix to address this issue. I'll provide ETA shortly.

abhinav-ghai commented 2 years ago

The issue should be fixed now, where can we check the results of latest run?

abhinav-ghai commented 2 years ago

This looks related to https://github.com/Azure/azure-sdk-for-js/pull/22029 change. This failing test is checking for MinItems constraint while passing empty values. Do we need to edit the test to look for a different error? Or since we are removing the constraint from SDK, remve this test altogether?

deyaaeldeen commented 2 years ago

Do we need to edit the test to look for a different error?

@abhinav-ghai that ^ should be fine.

sjiherzig commented 2 years ago

This has been resolved in #22363 . Nightly runs are green again: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1671647&view=results